Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix eclair-cli "compact" mode #2990

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Fix eclair-cli "compact" mode #2990

merged 2 commits into from
Feb 11, 2025

Conversation

sstone
Copy link
Member

@sstone sstone commented Jan 29, 2025

"compact" mode (-s option) needs to be updated after #2969

@sstone sstone requested a review from t-bast January 29, 2025 13:57
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, that means I also need to update it in #2968

Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually can we wait and merge this after #2968 and make the changes for this PR as well at the same time? Otherwise I'll need to rebase...

@sstone
Copy link
Member Author

sstone commented Jan 29, 2025

Actually can we wait and merge this after #2968 and make the changes for this PR as well at the same time? Otherwise I'll need to rebase...

Yes it makes sense, I'll wait for #2968

eclair-core/eclair-cli Outdated Show resolved Hide resolved
@t-bast
Copy link
Member

t-bast commented Feb 10, 2025

This can now be rebased and fixed to work with the optional channelAnnouncement_opt.shortChannelId!

"compact" mode (-s option) was broken after changes in how we manage short channel ids.
@sstone
Copy link
Member Author

sstone commented Feb 11, 2025

This can now be rebased and fixed to work with the optional channelAnnouncement_opt.shortChannelId!

done in 053400e

@sstone sstone merged commit 9b91c16 into master Feb 11, 2025
1 check passed
@sstone sstone deleted the fix-eclair-cli branch February 11, 2025 10:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants