More Fun with Timeouts #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for paramiko's behavior of always opening the channel in blocking mode, only applying the timeout kwarg to the initial connection.
|
@JennToo do we need to get the Coveralls check passing on this? And if so, do you have a preference between having me write a test to cover these two lines of code vs increasing coverage somewhere else? |
|
Ah sorry I lost the initial email about this. I wouldn't sweat the coveralls thing |
JennToo
approved these changes
Dec 9, 2024
|
Released in 3.1.3 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #45, I erroneously believed that a call to Paramiko's
Transport.open_channel()with thetimeoutkwarg would set a timeout on the resulting Paramiko channel object. As discussed at #28 (comment), that timeout only pertains to opening the channel. There is a separate instance method to set the timeout for subsequent channel IO, which is implemented here.Given this updated understanding of the timeout parameter in
open_channel(), I have changed that timeout fromgeneral_timeouttoinitial_timeout. I am not attached to this decision if others disagree. I also added a detailed comment with link to the relevant Paramiko code, so that anybody subsequently reading this code may better understand what it is doing and why.Closes #28
Builds on #45