Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make plugin compatible with FoC/Crud #23

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Make plugin compatible with FoC/Crud #23

merged 1 commit into from
Jul 12, 2018

Conversation

Spriz
Copy link
Contributor

@Spriz Spriz commented Jul 12, 2018

They made a similar solution: https://github.com/FriendsOfCake/crud/blob/master/aliases.php

however I get following error

PHP Warning:  Cannot declare class Cake\Http\Exception\NotFoundException, because the name is already in use in /var/www/apacta/vendor/friendsofcake/crud/aliases.php on line 17
PHP Stack trace:
PHP   1. {main}() /var/www/apacta/vendor/phpunit/phpunit/phpunit:0
PHP   2. require() /var/www/apacta/vendor/phpunit/phpunit/phpunit:51
PHP   3. ComposerAutoloaderInitc5f18fedf80ea89a4186f61d865fa6d8::getLoader() /var/www/apacta/vendor/autoload.php:7
PHP   4. composerRequirec5f18fedf80ea89a4186f61d865fa6d8() /var/www/apacta/vendor/composer/autoload_real.php:56
PHP   5. require() /var/www/apacta/vendor/composer/autoload_real.php:66
PHP   6. class_alias() /var/www/apacta/vendor/friendsofcake/crud/aliases.php:17

They made a similar solution: https://github.com/FriendsOfCake/crud/blob/master/aliases.php

however I get following error 
```
PHP Warning:  Cannot declare class Cake\Http\Exception\NotFoundException, because the name is already in use in /var/www/apacta/vendor/friendsofcake/crud/aliases.php on line 17
PHP Stack trace:
PHP   1. {main}() /var/www/apacta/vendor/phpunit/phpunit/phpunit:0
PHP   2. require() /var/www/apacta/vendor/phpunit/phpunit/phpunit:51
PHP   3. ComposerAutoloaderInitc5f18fedf80ea89a4186f61d865fa6d8::getLoader() /var/www/apacta/vendor/autoload.php:7
PHP   4. composerRequirec5f18fedf80ea89a4186f61d865fa6d8() /var/www/apacta/vendor/composer/autoload_real.php:56
PHP   5. require() /var/www/apacta/vendor/composer/autoload_real.php:66
PHP   6. class_alias() /var/www/apacta/vendor/friendsofcake/crud/aliases.php:17
```
@codecov
Copy link

codecov bot commented Jul 12, 2018

Codecov Report

Merging #23 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #23   +/-   ##
=========================================
  Coverage     90.41%   90.41%           
  Complexity       52       52           
=========================================
  Files             3        3           
  Lines           146      146           
=========================================
  Hits            132      132           
  Misses           14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e716f...a41ac13. Read the comment docs.

@ADmad
Copy link
Owner

ADmad commented Jul 12, 2018

The aliasing is done by your's truly in Crud too :) I just forgot to add alias for NotFoundException.

@ADmad ADmad merged commit b6f421e into ADmad:master Jul 12, 2018
@Spriz
Copy link
Contributor Author

Spriz commented Jul 13, 2018

I made #25 to fix it properly @ADmad ;P

@Spriz Spriz deleted the patch-1 branch September 18, 2018 14:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants