Revert Kokkos by default #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The device-side MPI buffer issue #46 turned out to be a Kokkos issue in version 4.2+. Rather than be a good citizen and chase it down to try to report coherently, I am for now simply reverting to 4.0.01.
I would use 4.1, but there's an unrelated issue in that version which causes a crash (something about freeing scratch space). That issue is fixed in 4.2, but...
The untested part of this PR is a facility to update to 4.2/develop when using HIP, as it doesn't suffer from this issue and benefits from latest Kokkos. Going to at least test/play with that before merging.