Refactoring - Split core.py into smaller files #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IrvingMg
force-pushed
the
split-core-into-smaller-files
branch
from
e7b3296 to
f018ea7
Compare
IrvingMg
force-pushed
the
split-core-into-smaller-files
branch
7 times, most recently
from
783700d to
746d150
Compare
IrvingMg
requested review from
Obliviour,
44past4,
sharabiani,
pawloch00,
BluValor and
gcie
as code owners
IrvingMg
changed the title
IrvingMg
force-pushed
the
split-core-into-smaller-files
branch
from
746d150 to
5b68583
Compare
|
cc: @pawloch00 |
pawloch00
reviewed
Feb 14, 2025
| command = ( | ||
| 'kubectl apply -f ' | ||
| # pylint: disable=line-too-long | ||
| 'https://raw.githubusercontent.com/GoogleCloudPlatform/container-engine-accelerators/master/gpudirect-tcpx/nccl-tcpx-installer.yaml' |
There was a problem hiding this comment.
can we have this link moved to separate variable
pawloch00
reviewed
Feb 14, 2025
|
|
||
| if system.accelerator_type == AcceleratorType['GPU']: | ||
| # For GPUs, it has two more spaces ahead of name and value respectively | ||
| env_format = ''' |
There was a problem hiding this comment.
can we turn this strings into dictionaries?
|
Can we have files inside core directory grouped into packages? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Testing / Documentation
Testing details.