Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Cmake tweaks #336

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Cmake tweaks #336

merged 2 commits into from
Sep 27, 2022

Conversation

andresailer
Copy link
Member

Just some things I found slightly annoying

BEGINRELEASENOTES

  • podioConfig.cmake: silence warning about cmake policy CMP00012
  • CMake: explicitly look for catch2 version 3 and fail at cmake instead of compile step

ENDRELEASENOTES

@andresailer
PodioConfig: set ENABLE_SIO variable to avoid warning about cmake pol…
d6f1de4 
…icy CMP0012 in downstream packages
@andresailer
CMake: Explicitly require version 3 (or newer) for Catch2
09b6b30 
Avoid finding version 2 of Catch2, e.g., on lcg stacks
tmadlener
tmadlener approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@tmadlener tmadlener merged commit 78cd3a0 into AIDASoft:master Sep 27, 2022
@andresailer andresailer deleted the cmakeTweaks branch September 27, 2022 12:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresailer @tmadlener