Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix path in the README and simplify option parsing #356

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Fix path in the README and simplify option parsing #356

merged 4 commits into from
Dec 6, 2022

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Fix path in the README
  • Use the functionality in argparse to choose between options

ENDRELEASENOTES

Now using --help will tell us about the possible choices

tmadlener
tmadlener reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that is very nice. I wasn't aware of choices in argparse.

I really just have a very minor comment for the README, where we technically do not have to create all the subdirectories.

@jmcarcell @tmadlener
Remove unneeded commands in the README
dcdf1a2 
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
@tmadlener tmadlener merged commit c19e427 into AIDASoft:master Dec 6, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcarcell @tmadlener