Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use sio utility functionality for writing also in legacy writer #363

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Use sio utility functionality for writing also in legacy writer #363

merged 4 commits into from
Jan 16, 2023

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Dec 23, 2022 •
edited
Loading

BEGINRELEASENOTES

  • Move sio utility functionality defined in SIOFrameWriter.cc to private sioUtils.h header and use it also in the legacy SIOWriter.
  • Fix cmake configure dependencies (missed in Python bindings for Frame #343) for datamodel generation macro.
  • Use defaultdict instead of hand rolling one in class generator.

ENDRELEASENOTES

@tmadlener tmadlener changed the title Some code movement and smaller fixes Use sio utility functionality for writing also in legacy writer Dec 23, 2022
@tmadlener tmadlener mentioned this pull request Dec 23, 2022
Merged
13 tasks
@tmadlener tmadlener merged commit 52064ba into AIDASoft:master Jan 16, 2023
@tmadlener tmadlener deleted the prep-edm-def-store branch January 16, 2023 16:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tmadlener