Make SIOFrameData work properly with dropped collections #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
SIOFrameData::getAvailableCollectionsto also work with Frames where some of the collections have not been written and that could lead to a seg fault.ENDRELEASENOTES
Previously obtaining all collection names relied on the fact that the indices in the
m_blocksblock list aligned with the order of the collectionID table. It worked if the collectionIDs were contiguous (which is the case if no collections are dropped during writing). Since the order of the collIDs in the table coincides with the indices of them_blocks, we use that to get the correct name.