Remove the deprecated getters and setters from the generic parameters #415
Conversation
|
Done, I checked and didn't find any places in the key4hep stack. This makes public the |
| return getMap<std::string>(); | ||
| } | ||
|
|
||
| private: |
There was a problem hiding this comment.
Maybe we can keep them private and make the SIO parts that need them friends. Since they are not publicly used anywhere yet, it would be quite nice to not have them public if it is not necessary.
There was a problem hiding this comment.
Yap. I would very much prefer that too
There was a problem hiding this comment.
Ok now they are friends although I find it not very elegant with the #ifdefs and the extra include, unless there is an easier way of doing it
include/podio/GenericParameters.h
Outdated
| #if PODIO_ENABLE_SIO | ||
| #include <sio/definitions.h> | ||
| #endif |
There was a problem hiding this comment.
this should work by simply forward declare these unconditionally, I think?
namespace sio {
class write_device;
class read_device;
using version_type = uint32_t; // from sio/definitions
}There was a problem hiding this comment.
Now it's done that way
|
This PR makes DD4hep not build for versions before 1.24; that is when the deprecated functions were removed |
|
Maybe also make a PR to dd4hep itself to increas the min version of podio if it is not already high enough? |
|
It's 0.16, but the issue here is with older versions of dd4hep, develop has already removed the deprecated stuff |
|
It looks like the |
BEGINRELEASENOTES
ENDRELEASENOTES
It's the one year birthday this week of the commit that marked them as deprecated so it has been a long time that they have been deprecated and I don't think they are being used much if at all.