Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make Catch2 setup more robust against podios in environment #425

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

tmadlener
Copy link
Collaborator

@tmadlener tmadlener commented Jun 7, 2023

BEGINRELEASENOTES

  • Add a SKIP_CATCH_DISCOVERY cmake option to skip the unittest discovery of Catch2 to avoid running the catch discovery in an unsuitable environment.
  • Make environment for unittests more specific to avoid catching too much of the underlying environment.

ENDRELEASENOTES

Currently this can be quite annoying if there is another podio installation in the environment because the test discovery is then run in an unsuitable environment which can lead to errors during dynamic library loading.

@tmadlener tmadlener force-pushed the robust-local-builds branch from 37ad6df to 4f1ff6f Compare June 7, 2023 13:57
@hegner
Copy link
Collaborator

hegner commented Jun 7, 2023

Thanks @tmadlener . Looks fine to me. Should I merge after tests finish/succeed?

@tmadlener
Copy link
Collaborator Author

Sounds good to me. The key4hep nightlies are broken at the moment, python is not picking up the key4hep python . I have adapted the python unittest to use python3 which should work.

(but now github seems to have degraded service, so it might take a while until this appears here)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants