Hide the JSON output functionality from CLING #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2023
wdconinc
added a commit
to eic/eic-spack
that referenced
this pull request
Jul 14, 2023
### Briefly, what does this PR introduce? This backports AIDASoft/podio#452 into 0.16.[4-5] for testing.
|
Confirming this works fine with EDM4hep 0.7.2 in our stack, no more to_json failures in running ROOT macros. |
|
Thanks for the quick testing. I am also backporting this to the v00-16-06 patch release. |
tmadlener
added a commit
to tmadlener/podio
that referenced
this pull request
Jul 14, 2023
hegner
pushed a commit
to hegner/podio
that referenced
this pull request
Jul 27, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
to_jsonfunctionality to not be visible inrootclingor the root interpreter. FixesPODIO_JSON_OUTPUTnot set downstream, but json support still compiled into libraries #435ENDRELEASENOTES
@wdconinc thanks for the hint with
__CLING__, wouldn't have thought of that. Could you check if this is indeed enough to fix the issue. The example in #435 works for me, but that might not be the end of the story.