Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix I/O issues of subset collections with vector members #463

Merged
merged 12 commits into from
Jul 26, 2023
Merged

Fix I/O issues of subset collections with vector members #463

merged 12 commits into from
Jul 26, 2023

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Make sure to only access vector member buffers of collections of datatypes with VectorMembers if they actually exist. This is necessary to make subset collections of such datatypes work in I/O. Fixes #462
  • Add a test that reproduces the original issue and is fixed by this.

ENDRELEASENOTES

hegner
hegner requested changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@hegner hegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic and new tests seem fine to me. Just some nitpicking about formatting and typos. See comments.

@tmadlener tmadlener force-pushed the fix-subset-coll-vec-mem branch from 336c381 to a336ca0 Compare July 25, 2023 12:18
@tmadlener tmadlener force-pushed the fix-subset-coll-vec-mem branch from a336ca0 to 81427f9 Compare July 25, 2023 12:23
@tmadlener
Copy link
Collaborator Author

Now also fixing the second issue reported in #462 (comment)

Unless we want to have that in another PR?

@tmadlener tmadlener force-pushed the fix-subset-coll-vec-mem branch from 2264489 to 6880541 Compare July 25, 2023 13:48
@tmadlener tmadlener force-pushed the fix-subset-coll-vec-mem branch from 36833dc to 2140675 Compare July 25, 2023 14:12
@hegner hegner merged commit dbf9425 into AIDASoft:master Jul 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@hegner hegner hegner requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Subset collections of datatypes with VectorMembers do not work
2 participants
@tmadlener @hegner