Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CI: use clang16 nightly builds #469

Merged
merged 6 commits into from
Aug 22, 2023
Merged

CI: use clang16 nightly builds #469

merged 6 commits into from
Aug 22, 2023

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Aug 21, 2023 •
edited by tmadlener
Loading

BEGINRELEASENOTES

  • Tests: update required catch2 version to 3.4 for builds with c++20
  • CI: use clang16 on el9 (alma9), instead of clang12 on cs7, using c++20
  • CI: disable key4hep-release-based tests (tabulate available)

ENDRELEASENOTES

Hmm: these nightly builds are with c++20...

@andresailer andresailer linked an issue Aug 21, 2023 that may be closed by this pull request
The clang12 nightlies no longer exist #468
Closed
1 task
@tmadlener
Copy link
Collaborator

Hmm: these nightly builds are with c++20...

Looking forward to those results, although at this point nothing interesting should happen ...

@andresailer
Copy link
Member Author

c++20 needs a newer version of catch2

@andresailer andresailer force-pushed the clang16 branch 2 times, most recently from 04a6da0 to a114b70 Compare August 21, 2023 14:11
@andresailer andresailer requested a review from tmadlener August 21, 2023 14:15
@andresailer
Copy link
Member Author

key4hep stack still fails, now complaining about too old catch2

  CMake Error at tests/unittests/CMakeLists.txt:10 (find_package):
    Could not find a configuration file for package "Catch2" that is compatible
    with requested version "3.1".

What do you want to do about this: Abort? Retry? Ignore?

@andresailer @tmadlener
CI: key4hep use AUTO for catch2
684fbb7 
Co-authored-by: Thomas Madlener <thomas.madlener@desy.de>
@tmadlener
Copy link
Collaborator

No tabulate yet in the key4hep release. In that case I would vote for removing the RNTUPLE matrix for the key4hep workflows again, and instead wait for a new release where everything should work again.

@andresailer
Copy link
Member Author

So just drop the key4hep-release based build you mean?

tmadlener
tmadlener approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Just need to remember to re-enable the key4hep release once it can be used again.

Thanks for taking care of this.

@tmadlener tmadlener merged commit fe8481b into AIDASoft:master Aug 22, 2023
tmadlener pushed a commit to tmadlener/podio that referenced this pull request Aug 30, 2023
@andresailer @tmadlener
CI: use clang16 nightly builds (AIDASoft#469)
0341935 
* CI: use clang16 nightly builds

* CI: linux: add CXX_STANDARD variable and set for builds

* Tests: require newer catch2 version when using c++20, get latest catch2 v3 version for internal

* CI: key4hep use AUTO for catch2

* CI: disable key4hep release based build
@tmadlener tmadlener mentioned this pull request Aug 30, 2023
Merged
tmadlener pushed a commit that referenced this pull request Aug 30, 2023
@andresailer @tmadlener
CI: use clang16 nightly builds (#469)
a48a838 
* CI: use clang16 nightly builds

* CI: linux: add CXX_STANDARD variable and set for builds

* Tests: require newer catch2 version when using c++20, get latest catch2 v3 version for internal

* CI: key4hep use AUTO for catch2

* CI: disable key4hep release based build
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The clang12 nightlies no longer exist
2 participants
@andresailer @tmadlener