Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Do not import ROOT when using podio-dump --help #521

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Do not import ROOT when using podio-dump --help, otherwise it can take a while depending on the system only to print the help.

ENDRELEASENOTES

Small quality of life improvement to make it a bit less painful when running from cvmfs.

@tmadlener
Copy link
Collaborator

tmadlener commented Dec 1, 2023

Ah right, this changed with #484 I think. Previously the from podio import __version__ was exactly there to have a quick podio-dump --help and podio-dump --version.

I would propose to keep the current __version__ file because that is what "normal" python packages do and simply create a second podio_version.py with the same contents already at the cmake stage. That will also automatically make pre-commit and the tests happy, because they all assume that they are run before installing things.

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this.

@tmadlener tmadlener merged commit e0bffc8 into AIDASoft:master Dec 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants