Improve generated interface function name to obtain the actual type #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
interface-better-name
branch
from
83e7835 to
35a47c3
Compare
getValue mixes a bit too much implementation detail into the interface. Additionally, as is very short and reads well in this context.
tmadlener
force-pushed
the
interface-better-name
branch
from
35a47c3 to
67d378c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
getValuemethod in favor of theasmethod for generated interface types.ENDRELEASENOTES
getValuemixes a bit too much implementation detail into the interface. Additionally,asis very short and reads well in this context.