-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add a header file including all the collections #606
Merged
+41
−12
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b2c9317
Add a header file including all the collections
jmcarcell 480bebc
Add missing template
jmcarcell 4455306
Add newline
jmcarcell 6d97dbd
Address PR comments
jmcarcell 8e57faa
Add a header guard
jmcarcell b2942e3
Make the generated header name agree with agreed upon convention
tmadlener 6e8214e
Make sure that the header is also installed
tmadlener da17465
Rename template to better reflect generated header name
tmadlener 67c9a0c
Add new template to the documentation
tmadlener File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// AUTOMATICALLY GENERATED FILE - DO NOT EDIT | ||
|
||
#ifndef {{ package_name.upper() }}_{{ package_name }}_H | ||
#define {{ package_name.upper() }}_{{ package_name }}_H | ||
|
||
{% for name in includes %} | ||
#include "{{ incfolder }}{{ name }}" | ||
{% endfor %} | ||
|
||
#endif // {{ package_name.upper() }}_{{ package_name }}_H |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
set(PODIO_TEMPLATES | ||
${CMAKE_CURRENT_LIST_DIR}/Collection.cc.jinja2 | ||
${CMAKE_CURRENT_LIST_DIR}/Collection.h.jinja2 | ||
${CMAKE_CURRENT_LIST_DIR}/AllCollections.h.jinja2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only nitpicking comment would be to change the name of the jinja2 template as well There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done. |
||
${CMAKE_CURRENT_LIST_DIR}/CollectionData.cc.jinja2 | ||
${CMAKE_CURRENT_LIST_DIR}/CollectionData.h.jinja2 | ||
${CMAKE_CURRENT_LIST_DIR}/Component.h.jinja2 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we generate include guards here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added, although it should not matter much since the headers have their own