Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop unused comparison templates #610

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Drop unused comparison templates

ENDRELEASENOTES

It has been a while since they have been introduced and are not in use so they can be deleted.

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the full stack still build with this? I probably introduced for the migration, but if things build, I am fine with removing these.

@hegner
Copy link
Collaborator

hegner commented May 28, 2024

Same with me. I wouldn't mind taking it out tonight and re-adding in case. But I doubt there will be problems

@jmcarcell
Copy link
Member Author

jmcarcell commented May 28, 2024

At least the core: EDM4hep, k4FWCore and the wrapper are fine with this, so I'm also in favor of checking with the nightlies.

@hegner hegner merged commit d0d0f55 into AIDASoft:master May 28, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants