Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix one to one relations for cloned objects #632

Merged
merged 2 commits into from
Jun 23, 2024

Conversation

jmcarcell
Copy link
Member

@jmcarcell jmcarcell commented Jun 23, 2024

Fixes #631. In #583, one to one relations were not added together with the one to many relations.

BEGINRELEASENOTES

  • Fix one to one relations for cloned objects by copying the one to one relations too.
  • Add a test that checks values for cloned objects from a non mutable object.

ENDRELEASENOTES

Copy link
Contributor

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, thanks.

@hegner hegner merged commit d12f4df into AIDASoft:master Jun 23, 2024
13 of 18 checks passed
@tmadlener
Copy link
Collaborator

@veprbl I will make a new v1.0.1 tag with these fixes in, unless there is more that is breaking on your side.

@veprbl
Copy link
Contributor

veprbl commented Jun 26, 2024

@tmadlener That would be nice to have. There are no other regressions that I'm aware of.

@veprbl
Copy link
Contributor

veprbl commented Jun 26, 2024

Ah, I see 01-00-01 is a thing already. Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneToOne relations are not preserved on clone() since v01-00
4 participants