Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make sure subset collections do not duplicate information when dumped to JSON #640

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Make JSON dumping of subset collections only store the ObjectIDs to the elements they are pointing to instead of duplicating the information.
  • Add JSON conversion support to podio::ObjectID
    • Use this to simplify JSON conversion code for relations in objects

ENDRELEASENOTES

@@ -5,6 +5,10 @@
#include <iomanip>
#include <ostream>

#if defined(PODIO_JSON_OUTPUT) && !defined(__CLING__)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have to watch out for this combination of flags. If we move it more often, we should replace it with a single combined one.

@hegner hegner merged commit 6b9c8d0 into AIDASoft:master Jul 25, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants