Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add two checks not to crash when a file doesn't exist or can't be opened #666

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jmcarcell
Copy link
Member

BEGINRELEASENOTES

  • Add two checks not to crash when a file doesn't exist or can't be opened and when an empty list is passed to makeReader.

ENDRELEASENOTES

and when an empty list is passed to makeReader.
Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose these would be caught by the actual readers, but we need them here as well, because we need to peek into the file?

@jmcarcell
Copy link
Member Author

jmcarcell commented Sep 6, 2024

Yes, right now it crashes if the file doesn't exist because file is a nullptr. When there are N files only the first one is checked with this, the rest will be checked by the respective reader.

Copy link
Collaborator

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks.

@tmadlener tmadlener merged commit 5618179 into AIDASoft:master Sep 6, 2024
18 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants