generate_image_prompts.py unnecessary txt embeddings #291
+0
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptilon:
Deleted unnecessary ' ' (text) embeddings that cause a dimension error when stacked to image embeddings.
Explanation
The script to generate image embeddings was reclycled from the one used for text embeddings generation.
This causes not only unnecessary text embeddings but a bug in which a dimension error shows up.
To be more specific, the line 37 that said:
txt_feats = txt_feats.reshape(-1, txt_feats.shape[-1]).cpu().data.numpy()
Has the correct dimensions to be stored directly. However, after appending it to a list and np.stack it with the images embeddings (notice the [0] before converting it to numpy)
img_feats = img_feats.reshape(-1, img_feats.shape[-1])[0].cpu().data.numpy()
the dimensions of the np arrays to stack were not compatible.
This can be solved in two ways.
txt_feats = txt_feats.reshape(-1, txt_feats.shape[-1])[0].cpu().data.numpy()
(notice the [0])