Numpy 2.0 compatibility #2392
Merged
Numpy 2.0 compatibility #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2392 +/- ##
========================================
Coverage 36.66% 36.66%
========================================
Files 103 103
Lines 14881 14881
Branches 1388 1388
========================================
Hits 5456 5456
Misses 9116 9116
Partials 309 309
Flags with carried forward coverage won't be shown. Click here to find out more. |
Fixes `AttributeError: `np.infty` was removed in the NumPy 2.0 release. Use `np.inf` instead.`
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: pypi/oldest-supported-numpy@2023.12.21, pypi/oldest-supported-numpy@2023.12.21 |
FFroehlich
approved these changes
Jun 16, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oldest-supported-numpyis no longer necessary, see numpy docs for detailsFixes
AttributeError:np.inftywas removed in the NumPy 2.0 release. Usenp.infinstead.Missed in np.Inf -> np.inf for numpy 2.0 compatibility #2422.
NOTE: There are some test failures (all of type
ValueError: could not convert string to float: 'np.float64(0.10132835605031565)') related to today's numpy 2.0 release which is incompatible with the current sympy 1.12. This will be fixed in sympy 1.13 for which there is already a release candidate and which I guess will be released shortly, so I would ignore those in amici for now.Closes #2377