Use SingleStreamRegion and NoSyncRegion in MLMG solve #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -374,6 +374,9 @@ | |||
| { | |||
| BL_PROFILE("MLMG::solve()"); | |||
|
|
|||
| [[maybe_unused]] Gpu::SingleStreamRegion single_strean_reg; | |||
| [[maybe_unused]] Gpu::NoSyncRegion no_sync_reg; | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
| @@ -374,6 +374,9 @@ | |||
| { | |||
| BL_PROFILE("MLMG::solve()"); | |||
|
|
|||
| [[maybe_unused]] Gpu::SingleStreamRegion single_stream_reg; | |||
Check notice
Code scanning / CodeQL
Unused local variable Note
WeiqunZhang
reviewed
Mar 11, 2025
| @@ -374,6 +374,9 @@ MLMGT<MF>::solve (const Vector<AMF*>& a_sol, const Vector<AMF const*>& a_rhs, | |||
| { | |||
| BL_PROFILE("MLMG::solve()"); | |||
|
|
|||
| [[maybe_unused]] Gpu::SingleStreamRegion single_stream_reg; | |||
There was a problem hiding this comment.
Maybe we should make this a runtime option. For example, maybe we can add a member function MLMG::setNoGpuSync to control whether we want to avoid gpu sync if possible (and use single stream for safety).
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additional background
Checklist
The proposed changes: