Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

User function can modify sample title. Use during scan sequence. #440

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

prjemian
Copy link
Contributor

In changes to fix #428, the user will be able to change the sample name. This enables sample names based on conditions that change during a long of sequence of scans, such as a temperature series.

@prjemian prjemian added the enhancement New feature or request label Nov 23, 2020
@prjemian prjemian added this to the 2020-11 operations milestone Nov 23, 2020
@prjemian prjemian requested a review from jilavsky November 23, 2020 20:24
@prjemian prjemian self-assigned this Nov 23, 2020
Copy link
Contributor

@jilavsky jilavsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. I understand this. Will need some examples to work with. Let's look at Linkam temperature and time from a specific moment. We may need to add PV for "start time"?

@jilavsky jilavsky merged commit ffeb86f into master Nov 24, 2020
@prjemian
Copy link
Contributor Author

I might have some code (in an IOC database) to help you with marking the specific moment. I created that code for marking the time when an area detector acquisition started. Looks very easy to use for this purpose, as well.

Or, we use Python code and mark the specific moment by recording specific_moment = time.time() and then use that.

@prjemian prjemian deleted the 428-dynamic-sample-name branch November 24, 2020 15:12
@prjemian
Copy link
Contributor Author

Temperature example (based on linkam_ci94.record_signal(), line 141):

def add_linkam_temperature(title):
    return f"{title}_{linkam_ci94.get():.2f}{linkam_ci94.units.get()}"

Reference: https://github.com/APS-USAXS/ipython-usaxs/blob/7270f66eacc172d26c041c66c433a25f2de32abb/profile_bluesky/startup/instrument/devices/linkam.py#L138-L144

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to append extra info in sample/file name
2 participants