Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

511 add laser distance meter #512

Merged
merged 11 commits into from
Jul 20, 2021
Merged

511 add laser distance meter #512

merged 11 commits into from
Jul 20, 2021

Conversation

jilavsky
Copy link
Contributor

resolves #511

jilavsky added 10 commits July 14, 2021 13:12
@jilavsky
Create laser.py
f4e51ca 
Added new device for laser AR500
@jilavsky
Testing
b76eb0e
@jilavsky
Update laser.py
b4bd3c1
@jilavsky
Fix commands
94ddddc
@jilavsky
fixes
62ffe99 
Rename into laser, why can't I see it as device in command line?
@jilavsky
Update laser.py
8c3630a
@jilavsky
Update laser.py
419089f
@jilavsky
Update __init__.py
944871b 
OK< need to also import it here?
@jilavsky
PV fixes
994c4b6
@jilavsky
Update laser.py
98910f9 
Fixes to make more readable description
@jilavsky jilavsky added the enhancement New feature or request label Jul 14, 2021
@jilavsky jilavsky added this to the 2021-02 July operations milestone Jul 14, 2021
@jilavsky jilavsky requested a review from prjemian July 14, 2021 20:55
prjemian
prjemian suggested changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as noted

profile_bluesky/startup/instrument/plans/mode_changes.py Show resolved Hide resolved
@jilavsky
Resolver review comments
523822e 
Remove _in from dx/dy and add proper .put to comments.
@jilavsky
Copy link
Contributor Author

@prjemian comments resolved. Ready to merge?

prjemian
prjemian approved these changes Jul 20, 2021
View reviewed changes
Copy link
Contributor

@prjemian prjemian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jilavsky jilavsky merged commit c39bcc0 into master Jul 20, 2021
@jilavsky jilavsky deleted the 511-add-laser-distance_meter branch July 20, 2021 19:33
@jilavsky jilavsky restored the 511-add-laser-distance_meter branch July 21, 2021 15:05
@jilavsky jilavsky mentioned this pull request Nov 12, 2021
Closed
@prjemian prjemian deleted the 511-add-laser-distance_meter branch January 31, 2022 16:23
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@prjemian prjemian prjemian approved these changes

Assignees

@prjemian prjemian

Labels
enhancement New feature or request
Projects
None yet
Milestone
2021-02 July operations
Development

Successfully merging this pull request may close these issues.

Add Laser distance meter AR500
2 participants
@jilavsky @prjemian