Add nullable FtpClientParameters to FtpConfig #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreaCuneo
requested changes
Jan 2, 2024
There was a problem hiding this comment.
ArxOne one implementation details should not be exposed in the generic interface. The approach is not right and the configuration should be exposed only within the ArxOne provider package. Also as a Action since the current implementation already provide some sensible defaults over the ArxOne library.
AndreaCuneo
requested changes
Jan 4, 2024
AndreaCuneo
requested changes
Jan 4, 2024
AndreaCuneo
requested changes
Jan 4, 2024
AndreaCuneo
approved these changes
Jan 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional Ftp Client Parameters to FtpConfig so user can include custom setup.