new QVP functions #807
new QVP functions #807
Conversation
|
Hi @meteoswiss-mdr , thank you for the pull request! I will be able to take a look next week, but I reran travis for now. Looks like it failed on their end. |
|
Thank you. Let me know if there are any issues. |
|
@zssherman, any news on this one? |
|
Hey Jordi,
Zach has been out sick. Will get to this soon
…-sent from a mobile device-
On Feb 27, 2019, at 6:58 AM, Radar, Satellite and Nowcasting Division ***@***.***> wrote:
@zssherman, any news on this one?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Sorry to hear that! I hope he is fine now. Let me know if you need any clarification |
|
@meteoswiss-mdr I apologize for the delay. With the release done, I now can review these enhancements. Thank you for the pull request! I will start reviewing it. |
|
@meteoswiss-mdr Just a few comments, for functions such as evp, rqvp etc, should the variables in the functions themselves and docstrings reflect evp rqvp, so under return for examples for rqvp, instead of saying qvp, have rqvp? Other comment I had was such a function like compute directional stats, maybe get moved to the utils sub module? @scollis Would you agree? |
|
Hi @zssherman, I agree on both points. |
|
@meteoswiss-mdr I currently am doing some changes and will submit a pull request to your branch. Do you possibly have unit tests for these new functions? |
|
Hi @zssherman, I do not have unit tests. I tested them by having a look on some processed data. I will see if I can have a look at your proposed changes next week. |
|
Fix conflict, working on how to approach unit testing. |
|
Actually going to close and create a new PR. |
Dear Py-ART masters,
I submit here a bunch of functions to compute a family of QVP-like products. They are stored in a radar-like object.
You can find the new functions in pyart/retrieve/qvp.py
Greetings from Switzerland!