-
Notifications
You must be signed in to change notification settings - Fork 3k
Change CMAKE_BINARY_DIR to CMAKE_CURRENT_BINARY_DIR #14272
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Change CMAKE_BINARY_DIR to CMAKE_CURRENT_BINARY_DIR #14272
Conversation
@ladislas, thank you for your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder where we would use CMAKE_BINARY_DIR
as we always related to the current target.
It looks like the current changes in this pull request should be current binary dir.
@0xc0170 I'm not sure I understand what you mean :) |
I might have not clearly stated, just that this change is all good. I am only wondering if the |
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Summary of changes
Following comment #14265 (comment), this PR changes the use of
CMAKE_BINARY_DIR
toCMAKE_CURRENT_BINARY_DIR
.This will put target specific files (
.elf
,.map
,.bin
,.hex
, etc.) in their respective target directories, like this:This change paves the way to "multiple target support" in the near future.
Impact of changes
None
Migration actions required
None
Documentation
None
Pull request type
Test results
Reviewers
@0xc0170 @hugueskamba @rwalton-arm @Patater @rajkan01