Skip to content

NUVOTON: Fix undeclared function as error #15500

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 24, 2024
Merged

NUVOTON: Fix undeclared function as error #15500

merged 7 commits into from
Apr 24, 2024

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Mar 18, 2024

Summary of changes

This PR fixes undeclared function as error on Nuvoton targets by e.g. Arm Compiler 6.21 with:

ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

ccli8 added 7 commits March 15, 2024 10:10
@ccli8
NUVOTON: EMAC: Fix undeclared function mbed_error_printf
4712f9d 
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
@ccli8
NUVOTON: AnalogIn: Fix undeclared function gpio_set
5a4a4fd 
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
@ccli8
NUVOTON: CAN: Fix undeclared function gpio_set
1be9ff0 
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
@ccli8
NUVOTON: AnalogOut: Fix undeclared function gpio_set
cf7a07f 
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
@ccli8
NUVOTON: SPI: Fix undeclared function gpio_set
4366b68 
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
@ccli8
NUVOTON: I2C: Fix undeclared function gpio_set
25c0491 
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
@ccli8
NUVOTON: Serial: Fix undeclared function gpio_set
11d9997 
ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
@ccli8
Copy link
Contributor Author

ccli8 commented Apr 3, 2024

Update?

@0xc0170 0xc0170 added needs: CI release-type: patch Indentifies a PR as containing just a patch labels Apr 10, 2024
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 12, 2024

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 12, 2024

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Apr 12, 2024
@ccli8
Copy link
Contributor Author

ccli8 commented Apr 24, 2024

@0xc0170 CI test log with error lost. Would you check the cause?

@0xc0170 0xc0170 merged commit 95fee2f into ARMmbed:master Apr 24, 2024
7 of 9 checks passed
@mergify mergify bot removed the ready for merge label Apr 24, 2024
@ccli8 ccli8 deleted the nuvoton_fix_function_undeclare branch April 25, 2024 01:13
@multiplemonomials multiplemonomials mentioned this pull request Jul 20, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-type: patch Indentifies a PR as containing just a patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ccli8 @0xc0170 @mbed-ci