-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Test overhaul #10291
Test overhaul #10291
Conversation
52cd19b
to
b0ed4ba
Compare
60a8025
to
3a99d2f
Compare
aaaaaa |
Sorry, it's just renaming files to match the usual py.test pattern of |
Will you update the wiki page with instructions for people to run tests on their own machines? https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Tests |
are you considering the question |
Sorry, missed the notif. Sure, I'll update the wiki if this gets merged 👍 |
While I was experimenting with command line arguments I used "--server-test" and I got something like this:
As you can see I stopped the execution with ctrl-c as I was not sure what was going on and why it was downloading additional model files, how many it would download - and most importantly - how these operations would affect my current webui install. Can anyone tell me whether the above operations made permanent changes to my webui install? The only documentation I could find about --test-sever (https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Tests) says very little and doesn't answer to my questions... I later found the partly downloaded model in "/home/myusername/.cache/huggingface/hub/..." and I deleted it.. but other than that I have no idea what else was changed. |
Although it might be too late to against this change, but I still want to bring into attention that this change just break all extensions’ github ci tests. Please consider still having “--tests”. |
@lllyasviel This happened a third of a year ago... |
I think this is related: #11441 |
Describe what this pull request is trying to achieve.
This PR is trying to enable a slightly more standard method of running tests, using Py.test.
It also enables coverage reporting - one could enable e.g. codecov.io or another service for tracking coverage metrics. Right now you can look at the output and HTML coverage reports in the Check Artifacts.
Additional notes and description of your changes
launch.py
with--test-server
configures it for tests, as it had done before with--tests ***
).Environment this was tested in