Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix undefined method 'exists?' for File:Class #165

Closed
wants to merge 0 commits into from

Conversation

matmorel
Copy link
Contributor

Hello,

This PR fixes #164 while keeping compatibility with ruby 2.x
Please let me know if any changes are needed.

Thanks

@matmorel matmorel changed the title Fix undefined method exists?' for File:Class` Fix undefined method 'exists?' for File:Class Apr 30, 2023
@AaronC81
Copy link
Owner

AaronC81 commented May 1, 2023

Thanks for the PR!
It's a neat approach, but I think it can be a lot simpler - File.exist? has existed alongside the now-removed exists? for a long time in Ruby 2, so I'm happy for the exists? to just be swapped with exist?.

If you'd like to update your PR to do this, then go ahead - but if not them I'm happy to make this quick change too!

@matmorel
Copy link
Contributor Author

matmorel commented May 2, 2023

Oh I didn't know that, updated

@AaronC81
Copy link
Owner

AaronC81 commented May 2, 2023

Thanks! Don't know what's going on with the CI... after work I'll try to fix that, get this merged, and put out a release 👍

@AaronC81
Copy link
Owner

AaronC81 commented May 2, 2023

Managed to completely screw up the rebase for this, but I have merged your PR on the command-line, and it is in master now! I'll do a release shortly

@AaronC81
Copy link
Owner

AaronC81 commented May 2, 2023

@matmorel 5.0.1 released, which contains this :)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ruby 3.2 support (File.exists? has been removed)
2 participants