Cli patch #5
Merged
Cli patch #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinGbz
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (bgd-labs#9) * fix: Remove unneeded diff file (bgd-labs#10) * feat: install aave-ccip at latest commit on aave/ccip#18 * chore: upd remappings, lib/aave-helpers, .assets * new: add proposal for eth & arb * fix: arb test supply locked invariant * fix: rename, add discussion link * upd: aave-ccip module * feat: add proxy pool deployments * feat: add e2e tests * chore: fix license, explicit senders for expectEmit * ci: override rpc url in secrets * test: proxy pool can off ramp * chore: reorder deps * nit: utilize existing ierc20 import, style guide, use arb assets for gho addy * feat: add rate limit, use gho fascilitator for tests * feat: set in bound rate limit as well * chore: cleanup * test: check proxy initialized version * chore: inBetween => inFlight" * chore: test name consistency * test: dynamically fetch dest gas amt * test: execMsg post migration using legacy off ramp * test: ccip steward can disable rate limit * chore: cleanup * doc: add comment for fetching all offramps, use RISK_COUNCIL for clarity * test: ownership transfer after migration * chore: rm _readRiskAdmin, fix config * fix: ci test setup to stay compatible with bdg upstream * feat: rm aave-ccip dep * rft: use deployed token pools * tmp: fix ci for aave org, to rm for bdg * fix: ci to bdg setup * fix: update rate limit * test: fuzz amounts * chore: snapshot docs * chore: const cap rate * chore: fix type * fix: Fix rate limit config constants * fix: tests, impl correct solc * fix: tests * Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Ethereum_GHOCCIP150Upgrade_20241021.sol Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com> * Update src/20241021_Multi_GHOCCIP150Upgrade/AaveV3Arbitrum_GHOCCIP150Upgrade_20241021.sol Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com> * doc: reference token pool contracts * doc: upgrade spec * doc: formatting * Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com> * Update src/20241021_Multi_GHOCCIP150Upgrade/GHOCCIP150Upgrade.md Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com> * test: Refresh block number with ghostewards aip executed * fix: Remove unneeded script --------- Co-authored-by: Parth Patel <parth4321patel@gmail.com> Co-authored-by: DhairyaSethi <55102840+DhairyaSethi@users.noreply.github.com> Co-authored-by: Harsh Pandey <harshsatishpandey@gmail.com>
Rozengarden
pushed a commit
that referenced
this pull request
Jan 17, 2025
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (bgd-labs#9) * fix: Remove unneeded diff file (bgd-labs#10) * chore: init aip * feat: ccip 1.5.1 upgrade * tmp: fix ci for aave org, to rm for bdg * tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed * tmp: fix ci for aave org * revert: test ci secrets updates * chore: fix comments * chore: rm duplicate check * chore: reorder imports, pending automation * chore: import order * chore: imports order, re-frame comment * feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment * chore: consistency, cleanup comment based on latest approach * upd: `directMint` & `directBurn` * feat: add `gho-core` lib temporarily, fix interface * feat: new gho ccip steward * feat: reference existing pool upgrade impl deployment * feat: more verbose and efficient * chore: upd ccip lib * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: updates based on upstream changes from bgd-labs#527 * chore: fix&add comment, use chain selector from helper lib * chore: fix chain selector lib typo * feat: accept existing proxy pool ownership as well * feat: add rate limit * feat: add deployed token pools & stewards * feat: rm `gho-core` & `ccip` * feat: upd arb token pool & steward deployment * feat: notify gho bucket steward * feat: update aave steward * chore: use existing IOwnable * chore: new ccip stewards with timelock getter * feat: use oz v5.1 proxies * doc: add discussion + spec * feat: chainlink pre-req have been performed * Updated GHOCCIP151Upgrade.md * Updated GHOCCIP151Upgrade.md Updated to permalinks * doc: lint and add steward addresses to spec md * doc: expand on bucket steward update --------- Co-authored-by: Parth Patel <parth4321patel@gmail.com> Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com> Co-authored-by: JP <89362795+CanonicalJP@users.noreply.github.com>
marczeller
pushed a commit
that referenced
this pull request
Feb 5, 2025
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (bgd-labs#9) * fix: Remove unneeded diff file (bgd-labs#10) * chore: init aip * feat: ccip 1.5.1 upgrade * tmp: fix ci for aave org, to rm for bdg * tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed * tmp: fix ci for aave org * revert: test ci secrets updates * chore: fix comments * chore: rm duplicate check * chore: reorder imports, pending automation * chore: import order * chore: imports order, re-frame comment * feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment * chore: consistency, cleanup comment based on latest approach * upd: `directMint` & `directBurn` * feat: add `gho-core` lib temporarily, fix interface * feat: new gho ccip steward * feat: reference existing pool upgrade impl deployment * feat: more verbose and efficient * feat: base expansion * chore: upd ccip lib * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: updates based on upstream changes from bgd-labs#527 * chore: fix&add comment, use chain selector from helper lib * chore: upd ccip lib * feat: expand _validateConfig in e2e test * feat: eth & arb tests * chore: import gho from EthereumAssets instead of MiscEthereum * chore: use latest deployment of existing remote pool upgrade * doc: snapshot & discussion * chore: rename facilitator * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: snapshot, use utils reference for chain selectors * fix: base config test on eth * test: eth<>arb e2e test * chore: mock naming accuracy * feat: base token through create2 * feat: expand _validateConfig in e2e test * feat: use deployed gho token impl on base, fix facilitator bucket to 20M instead of 25M * fix: merge latest upstream * chore: fix chain selector lib typo * fix: tmp fix remappings such that gho-core OZ and aave-v3 OZ do not collide * feat: stewards, base tests * fix: use 500 maxChange borrowRateConfig * feat: validate base proposal constants * chore: add partial explorer links for immutables * test: tokenPoolConfig * feat: accept existing proxy pool ownership as well * feat: add rate limit * test: fix risk council * fix: merge * feat: add rate limit * fix: riskCouncil * feat: gho base listing * feat: aave stewards test * chore: fix typo * chore: upd title * feat: add deployed token pools & stewards * feat: rm `gho-core` & `ccip` * feat: upd arb token pool & steward deployment * feat: use deployed base token pool & stewards * feat: notify gho bucket steward * feat: update aave steward * upd: upstream * chore: use existing IOwnable * chore: steward tests * fix: ccip stewards tests * test: listing pre-req negative cases * chore: minor cleanup * test: verbose error msg * feat: QoL cleanup * chore: new ccip stewards with timelock getter * chore: upd upstream * chore: new ccip stewards with timelock getter on base * feat: use oz v5.1 proxies * upd: use latest eth/arb deployments * feat: predeploy gho token * doc: upd md with new token * feat: update gho token proxyAdmin * test: simplify * chore: minor cleanup nits * chore: resolve conflicts * fix: update blocks, cleanup on pre-requisites * doc: update AIP text * test: 1.5.1 upgrade executed on chain, rm all prerequisites in tests * test: upd base block since all pre req are complete * chore: update spec md Co-authored-by: Ian Flexa <85500650+ianflexa@users.noreply.github.com> * fix: generate diff md again * Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (bgd-labs#9) * fix: Remove unneeded diff file (bgd-labs#10) * fix: rebase and update diffs, imports * chore: import token pools from address book * chore: fix lint on spec md * fix: update rates based on latest recc --------- Co-authored-by: Parth Patel <parth4321patel@gmail.com> Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com> Co-authored-by: Ian Flexa <85500650+ianflexa@users.noreply.github.com>
Rozengarden
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (bgd-labs#9) * fix: Remove unneeded diff file (bgd-labs#10) * chore: init aip * feat: ccip 1.5.1 upgrade * tmp: fix ci for aave org, to rm for bdg * tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed * tmp: fix ci for aave org * revert: test ci secrets updates * chore: fix comments * chore: rm duplicate check * chore: reorder imports, pending automation * chore: import order * chore: imports order, re-frame comment * feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment * chore: consistency, cleanup comment based on latest approach * upd: `directMint` & `directBurn` * feat: add `gho-core` lib temporarily, fix interface * feat: new gho ccip steward * feat: reference existing pool upgrade impl deployment * feat: more verbose and efficient * chore: upd ccip lib * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: updates based on upstream changes from bgd-labs#527 * chore: fix&add comment, use chain selector from helper lib * chore: fix chain selector lib typo * feat: accept existing proxy pool ownership as well * feat: add rate limit * feat: add deployed token pools & stewards * feat: rm `gho-core` & `ccip` * feat: upd arb token pool & steward deployment * feat: notify gho bucket steward * feat: update aave steward * chore: use existing IOwnable * chore: new ccip stewards with timelock getter * feat: use oz v5.1 proxies * doc: add discussion + spec * feat: chainlink pre-req have been performed * Updated GHOCCIP151Upgrade.md * Updated GHOCCIP151Upgrade.md Updated to permalinks * doc: lint and add steward addresses to spec md * doc: expand on bucket steward update --------- Co-authored-by: Parth Patel <parth4321patel@gmail.com> Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com> Co-authored-by: JP <89362795+CanonicalJP@users.noreply.github.com>
Rozengarden
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (bgd-labs#9) * fix: Remove unneeded diff file (bgd-labs#10) * chore: init aip * feat: ccip 1.5.1 upgrade * tmp: fix ci for aave org, to rm for bdg * tmp: add 1.4 pool with withdrawLiq flattended, to be removed once impl is deployed * tmp: fix ci for aave org * revert: test ci secrets updates * chore: fix comments * chore: rm duplicate check * chore: reorder imports, pending automation * chore: import order * chore: imports order, re-frame comment * feat: update to latest spec: naming changes, setCurrentBridgedAmount, resolve existing pool bridgeAmount comment * chore: consistency, cleanup comment based on latest approach * upd: `directMint` & `directBurn` * feat: add `gho-core` lib temporarily, fix interface * feat: new gho ccip steward * feat: reference existing pool upgrade impl deployment * feat: more verbose and efficient * feat: base expansion * chore: upd ccip lib * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: updates based on upstream changes from bgd-labs#527 * chore: fix&add comment, use chain selector from helper lib * chore: upd ccip lib * feat: expand _validateConfig in e2e test * feat: eth & arb tests * chore: import gho from EthereumAssets instead of MiscEthereum * chore: use latest deployment of existing remote pool upgrade * doc: snapshot & discussion * chore: rename facilitator * test: cleanup & fuzzify * test: cleanup & fuzzify * chore: use latest deployment of existing remote pool upgrade * doc: snapshot -> direct-to-aip * chore: import gho from EthereumAssets instead of MiscEthereum * chore: cleanup rm ProxyAdmin reference * chore: rename facilitator * chore: rm duplicate check * fix: snapshot, use utils reference for chain selectors * fix: base config test on eth * test: eth<>arb e2e test * chore: mock naming accuracy * feat: base token through create2 * feat: expand _validateConfig in e2e test * feat: use deployed gho token impl on base, fix facilitator bucket to 20M instead of 25M * fix: merge latest upstream * chore: fix chain selector lib typo * fix: tmp fix remappings such that gho-core OZ and aave-v3 OZ do not collide * feat: stewards, base tests * fix: use 500 maxChange borrowRateConfig * feat: validate base proposal constants * chore: add partial explorer links for immutables * test: tokenPoolConfig * feat: accept existing proxy pool ownership as well * feat: add rate limit * test: fix risk council * fix: merge * feat: add rate limit * fix: riskCouncil * feat: gho base listing * feat: aave stewards test * chore: fix typo * chore: upd title * feat: add deployed token pools & stewards * feat: rm `gho-core` & `ccip` * feat: upd arb token pool & steward deployment * feat: use deployed base token pool & stewards * feat: notify gho bucket steward * feat: update aave steward * upd: upstream * chore: use existing IOwnable * chore: steward tests * fix: ccip stewards tests * test: listing pre-req negative cases * chore: minor cleanup * test: verbose error msg * feat: QoL cleanup * chore: new ccip stewards with timelock getter * chore: upd upstream * chore: new ccip stewards with timelock getter on base * feat: use oz v5.1 proxies * upd: use latest eth/arb deployments * feat: predeploy gho token * doc: upd md with new token * feat: update gho token proxyAdmin * test: simplify * chore: minor cleanup nits * chore: resolve conflicts * fix: update blocks, cleanup on pre-requisites * doc: update AIP text * test: 1.5.1 upgrade executed on chain, rm all prerequisites in tests * test: upd base block since all pre req are complete * chore: update spec md Co-authored-by: Ian Flexa <85500650+ianflexa@users.noreply.github.com> * fix: generate diff md again * Add proposal for Gho Incident Report 20231113 (#1) * chore: add payload and deploy script for update of GHO variable debt token * forge install: gho-core * chore: add gho-core to dependency * test: Add tests for update of gho variable token * test: Add tests for update of gho variable token * fix: add modifier in method of interface * fix: remove gho dependency from repo and fix test * fix: Remove unnecesary dependency * fix: Add latest details --------- Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> * fix: Make new impl constant (#3) * fix: Amend AIP text (#4) * fix: Make new impl constant * fix: Fix AIP text * test: Tweak default tests with borrow cap update (#5) * fix: lint issue (#6) * test: Add diffs from test running (#7) * fix: Add payload address (#8) * fix: Fix payload address in script (bgd-labs#9) * fix: Remove unneeded diff file (bgd-labs#10) * fix: rebase and update diffs, imports * chore: import token pools from address book * chore: fix lint on spec md * fix: update rates based on latest recc --------- Co-authored-by: Parth Patel <parth4321patel@gmail.com> Co-authored-by: miguelmtzinf <miguelmtz.mail@gmail.com> Co-authored-by: miguelmtz <36620902+miguelmtzinf@users.noreply.github.com> Co-authored-by: Ian Flexa <85500650+ianflexa@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.