Updates for OSL v1.14 #2204
Merged
Updates for OSL v1.14 #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jstone-lucasfilm
commented
Jan 29, 2025
jstone-lucasfilm
commented
- Call the new subsurface_bssrdf closure in OSL v1.14 and above, falling back to the original closure signature in earlier versions.
- Call the new chiang_hair_bsdf closure in OSL v1.14 and above, falling back to a dielectric_bsdf approximation in earlier versions.
- Inline the OSL implementations of displacement nodes for simplicity.
- Update the minimum OSL and MDL versions in libraries documentation.
- Call the new subsurface_bssrdf closure in OSL v1.14 and above, falling back to the original closure signature in earlier versions. - Call the new chiang_hair_bsdf closure in OSL v1.14 and above, falling back to a dielectric_bsdf approximation in earlier versions. - Inline the OSL implementations of displacement nodes for simplicity. - Update the minimum OSL and MDL versions in libraries documentation.
|
Attaching a GLSL/OSL render comparison using the codebase in this PR: |
jstone-lucasfilm
merged commit fc388e4
into
AcademySoftwareFoundation:main
34 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.