Validate tree depth in XML parsing #2232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changelist adds validation for the current element depth in XML parsing, preventing an invalid document from triggering a stack overflow. A new unit test has been added to generate a document with invalid element depth, verifying that the error condition is correctly caught.
jstone-lucasfilm
changed the title
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit 51be1ba
into
AcademySoftwareFoundation:main
34 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changelist adds validation for the tree depth in XML parsing, preventing an invalid document from triggering a stack overflow.
A new unit test has been added to parse a document exceeding the maximum tree depth, verifying that the correct exception is thrown.