-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rqd reserve all cores #1296
base: master
Are you sure you want to change the base?
Rqd reserve all cores #1296
Conversation
…reserve precisely according to request (P-cores first, E-cores last)
This is an interesting change that never really got attention. I'm taking some time to study the architecture of hybrid system with P-cores and E-cores to understand what this PR is trying to accomplish. At a first glance, I like the direction it is taking, but I don't think it is documented properly. |
I'm finishing up a collection of changes that were pending on SPI's end and will keep this PR right at the top of my review list for when I finish. Sorry for the wait. |
I think this logic was never well documented and now is the perfect opportunity to do so, as most of the content is already on this PR. Can you add a blog post to opencue.io's repo? |
Aside from my question, I think this PR is ready to be merged. Did you have the change to tests it on a production environment to confirm:
|
Sure thing, I will do it soon :) |
Yes we did use it in production last year in my previous studio on our artists workstations, it was on RockyLinux with hybrid CPUs. |
Link the Issue(s) this Pull Request is related to.
#1295
Summarize your change.
Reserve only the requested amount of threads, taking into account hybrid system with P-cores and E-cores.
Pick cores in order, still with priority on less idle cpu.
I had to change a test to match the updated HT reservation algo.
Added a test for hybrid cpu (i9-12900)
Warning
Should bump minor version as it may impact some existing implementations (hacks) relying on wrong thread counts.