[rqd] Avoid changing dict in place during iteration #1554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting an item from the dict being iterated over on sanitizeFrames caused the error: "Dictionary changed size during iteration".
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
ramonfigueiredo
approved these changes
Oct 23, 2024
DiegoTavares
merged commit f7244dd
into
AcademySoftwareFoundation:master
12 checks passed
DiegoTavares
added a commit
to DiegoTavares/OpenCue
that referenced
this pull request
Oct 28, 2024
…oundation#1554) Deleting an item from the dict being iterated over on sanitizeFrames caused the error: "Dictionary changed size during iteration".
DiegoTavares
pushed a commit
that referenced
this pull request
Oct 31, 2024
**Link the Issue(s) this Pull Request is related to.** This fixes an bug introduced with #1554 **Summarize your change.** It fixes a small bug that hinders `rqd` to actually run any jobs. It probably didn't get chaught due to the unittests for rqd not working properly.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting an item from the dict being iterated over on sanitizeFrames caused the error: "Dictionary changed size during iteration".