Skip to content

Commit

Permalink
Fix ProcessDeletedEventConverterTest
Browse files Browse the repository at this point in the history
  • Loading branch information
igdianov committed Oct 2, 2024
1 parent f432ac2 commit 2561d12
Showing 1 changed file with 4 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@
package org.activiti.cloud.services.audit.jpa.converters;

import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.BDDMockito.given;

import java.util.Arrays;
import java.util.List;
Expand All @@ -37,7 +35,6 @@
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.data.domain.Sort;

@ExtendWith(MockitoExtension.class)
public class ProcessDeletedEventConverterTest {
Expand Down Expand Up @@ -65,10 +62,8 @@ public void createEventEntityShouldReturnEntity() {
//given
String processDefinitionId = UUID.randomUUID().toString();
String processInstanceId = UUID.randomUUID().toString();
given(eventsRepository.findAll(any(), any(Sort.class)))
.willReturn(buildCompletedEntities(processDefinitionId, processInstanceId));

CloudRuntimeEvent<?, ?> runtimeEvent = buildEvent(processInstanceId);
CloudRuntimeEvent<?, ?> runtimeEvent = buildEvent(processInstanceId, processDefinitionId);

//when
ProcessDeletedAuditEventEntity event = converter.createEventEntity(runtimeEvent);
Expand All @@ -83,10 +78,8 @@ public void createAPIEventShouldReturnEvent() {
//given
String processDefinitionId = UUID.randomUUID().toString();
String processInstanceId = UUID.randomUUID().toString();
given(eventsRepository.findAll(any(), any(Sort.class)))
.willReturn(buildCompletedEntities(processDefinitionId, processInstanceId));

CloudRuntimeEvent<?, ?> runtimeEvent = buildEvent(processInstanceId);
CloudRuntimeEvent<?, ?> runtimeEvent = buildEvent(processInstanceId, processDefinitionId);

//when
ProcessDeletedAuditEventEntity event = converter.createEventEntity(runtimeEvent);
Expand All @@ -97,9 +90,10 @@ public void createAPIEventShouldReturnEvent() {
assertThat(apiEvent.getProcessInstanceId()).isEqualTo(processInstanceId);
}

private CloudRuntimeEvent<?, ?> buildEvent(String processInstanceId) {
private CloudRuntimeEvent<?, ?> buildEvent(String processInstanceId, String processDefinitionId) {
ProcessInstanceImpl instance = new ProcessInstanceImpl();
instance.setId(processInstanceId);
instance.setProcessDefinitionId(processDefinitionId);

CloudProcessDeletedEventImpl event = new CloudProcessDeletedEventImpl(instance);
event.setProcessInstanceId(processInstanceId);
Expand Down

0 comments on commit 2561d12

Please # to comment.