AAE-22831 Fix status is changed to 'Cancelled' when deleting process instance #1543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igdianov
requested review from
andrea-ligios,
atchertchian and
erdemedeiros
igdianov
changed the title
atchertchian
approved these changes
Sep 19, 2024
igdianov
force-pushed
the
bug/AAE-22831-igdianov-fix-destroy-process-instance
branch
5 times, most recently
from
46f03b4 to
b27a469
Compare
erdemedeiros
reviewed
Oct 1, 2024
.../java/org/activiti/cloud/services/audit/jpa/converters/ProcessDeletedEventConverterTest.java
Show resolved
Hide resolved
...y-rest/src/main/java/org/activiti/cloud/services/query/rest/ProcessInstanceAdminService.java
Show resolved
Hide resolved
...rter-query/src/test/java/org/activiti/cloud/starter/tests/QueryProcessInstancesEntityIT.java
Show resolved
Hide resolved
...runtime-bundle/src/test/java/org/activiti/cloud/starter/tests/runtime/ProcessInstanceIT.java
Outdated
Show resolved
Hide resolved
igdianov
force-pushed
the
bug/AAE-22831-igdianov-fix-destroy-process-instance
branch
from
b27a469 to
57014a3
Compare
igdianov
force-pushed
the
bug/AAE-22831-igdianov-fix-destroy-process-instance
branch
from
57014a3 to
db33b4c
Compare
igdianov
force-pushed
the
bug/AAE-22831-igdianov-fix-destroy-process-instance
branch
from
195a723 to
12d950a
Compare
|
igdianov
deleted the
bug/AAE-22831-igdianov-fix-destroy-process-instance
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client is chaining two api calls for Process Instance DELETE which cancels the process followed by DESTROY, which sends a PROCESS_DELETED event to Query servicd.
After that, the client is trying to refresh the list of the processes, and if the DESTROY event is lagging, so it will get an intermediate CANCELLED status, but after refreshing the list again, the process will disappear from the Query database.
https://hyland.atlassian.net/browse/AAE-22831
This PR extends the destroy process instance REST api call to actually cancel the process execution in the Runtime in one transaction which will send the delete process instance cloud event to the Query service in one message.
The extended Runtime Admin API call will support a new
force=trueparameter to be able to destroy the process in one command:The existing destroy process api command without
forceparameter will work as before by declining to destroy if the status of the process is not CANCELLED or COMPLETED.