AAE-30611 spring boot update #1670
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojciech-piotrowiak
force-pushed
the
improvement/AAE-30611-spring-boot--update
branch
from
b7c89ae to
1fe7cb2
Compare
.github/workflows/main.yml
Outdated
| @@ -95,7 +95,7 @@ jobs: | |||
|
|
|||
| - name: Maven Build and Test | |||
| shell: bash | |||
| run: mvn -DskipAcceptanceTests=true -DunitTests.parallel=true -T 1C install ${{ env.MAVEN_CLI_OPTS}} ${{ env.SONAR_SCANNER_OPTS }} | |||
| run: mvn -DskipTests -DskipITs -DskipAcceptanceTests=true -DunitTests.parallel=true -T 1C install ${{ env.MAVEN_CLI_OPTS}} ${{ env.SONAR_SCANNER_OPTS }} | |||
There was a problem hiding this comment.
only to check if acceptance tests will be running
| @@ -33,7 +33,7 @@ | |||
| import org.springframework.test.context.ContextConfiguration; | |||
| import org.springframework.test.web.servlet.MockMvc; | |||
|
|
|||
| @SpringBootTest | |||
| @SpringBootTest("springdoc.override-with-generic-response=false") | |||
There was a problem hiding this comment.
this is due to incompability between springdoc 2.1 and current spring. Upgrading swagger/springdoc needs to be considered, there are some changes in generated schema
This reverts commit d916777.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.