Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: prevent KeyError: 'title' in filter_keyvals_regex() #123

Merged
merged 2 commits into from
Jul 7, 2023
Merged

fix: prevent KeyError: 'title' in filter_keyvals_regex() #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6a519b
Prevent `KeyError: 'title'` from happening in `filter_keyvals_regex` …
BelKed Jul 7, 2023
d61323b
Add a test to ensure `KeyError: 'title'` doesn't happen
BelKed Jul 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aw_transform/filter_keyvals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ def filter_keyvals_regex(events: List[Event], key: str, regex: str) -> List[Even
r = re.compile(regex)

def predicate(event):
return bool(r.findall(event.data[key]))
return key in event.data and bool(r.findall(event.data[key]))

return [e for e in events if predicate(e)]
10 changes: 10 additions & 0 deletions tests/test_transforms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,16 @@ def test_filter_keyval_regex():
assert len(events_re) == 2


def test_filter_keyval_regex_keyerror():
events = [
Event(data={"label": "aa"}),
Event(),
Event(data={"label": "cc"}),
]
events_re = filter_keyvals_regex(events, "label", "aa|cc")
assert len(events_re) == 2


def test_intersecting_eventpairs():
td1h = timedelta(hours=1)
now = datetime.now()
Expand Down