Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecated the Obsidian watcher in favor of the AW plugin for Obsidian #149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StoppingBuck
Copy link

@StoppingBuck StoppingBuck commented Mar 2, 2025

The Obsidian watcher seems to be dead, with the latest commit being 2 years ago and several issues mentioning it is broken.
By contrast, the ActivityWatch plugin for Obsidian works fine and does the exact same thing, just by having Obsidian push the information to AW instead of having AW watch for it.

This PR adds this information


Important

Deprecated aw-watcher-obsidian in favor of the ActivityWatch plugin for Obsidian in watchers.rst.

  • Deprecation:
    • Deprecated aw-watcher-obsidian in watchers.rst.
    • Added recommendation to use the ActivityWatch community plugin for Obsidian.

This description was created by Ellipsis for b3312e2. It will automatically update as commits are pushed.

Deprecated the Obsidian watcher in favor of the AW plugin for Obsidian
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b3312e2 in 1 minute and 23 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 7 drafted comments based on config settings.
1. src/watchers.rst:46
  • Draft comment:
    Using raw HTML for strike-through may not render uniformly across all output formats.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
    While the comment is technically correct about raw HTML potentially having rendering issues, this seems like a minor formatting concern. The strikethrough is being used to clearly mark something as deprecated, which is a valid use case. RST doesn't have native strikethrough support, so raw HTML is a common workaround. The comment doesn't suggest a better alternative.
    The comment could be valid if there are specific output formats where this would break badly. Also, there might be a more RST-native way to indicate deprecation.
    Even if there are edge cases where rendering might be inconsistent, the current solution works for the main use case of marking something as deprecated, and no better alternative is proposed.
    Delete the comment as it's a minor formatting concern without proposing a better solution, and the current approach serves its purpose of marking deprecation.
2. src/watchers.rst:50
  • Draft comment:
    Ensure the recommended bullet’s indentation is consistent; extra spaces might nest it unintentionally.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
3. src/watchers.rst:46
  • Draft comment:
    Using a raw HTML block for strikethrough may not render in non-HTML outputs.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 30% <= threshold 50%
    This comment is informative and suggests a potential issue with rendering in non-HTML outputs. However, it doesn't ask for a specific change or confirmation of intent. It seems to be more of a cautionary note rather than a directive or suggestion for improvement.
4. src/watchers.rst:50
  • Draft comment:
    Check list item indentation; the recommended bullet is indented differently than others.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50%
    None
5. src/watchers.rst:9
  • Draft comment:
    Typographical Error: In line 9, 'and it's url' should be 'and its URL'.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
6. src/watchers.rst:60
  • Draft comment:
    Typographical Error: In line 60, 'on you Chromecast device' should be corrected to 'on your Chromecast device'.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. src/watchers.rst:64
  • Draft comment:
    Typographical Issue: In line 64, consider adding a space after 'Last.fm' so it reads 'Last.fm (supports most streaming services including Apple Music)'.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_QM0PCX2k0Gy0qRIc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant