-
Notifications
You must be signed in to change notification settings - Fork 50
Improve yabai event-based stack #14
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Quoting from our convo on #13
Trading flicker for failing to update when a window is destroyed seems like kind of a sideways move. It could be argued that changing the focused window (and inducing flicker) is so much more common than closing/removing a window from a stack that it's worth it, but I'm not so sure. The flicker is annoying, but at least predictable. I think I'm going to leave this one open until we figure out if #8 has legs (which will hopefully occur next weekend). |
@AdamWagner this should be automatically fixed if this yabai PR is merged: koekeishiya/yabai#636 |
b89748b
to
e773b54
Compare
e773b54
to
cc15858
Compare
I looked through the codebase but I could not find a good reason for having a non-standard subrole for canvas windows. This would help yabai in [filtering out AXUnknown windows](koekeishiya/yabai#636) and in [drawing a window stack indicator](AdamWagner/stackline#14 (comment)) that only reacts to non-canvas windows
Change of plans, it would be better to fix this in Hammerspoon itself: Hammerspoon/hammerspoon#2427 |
@AdamWagner could you please review this again when you have some time? 😊 |
Really great idea to move the yabai signals out of the readme and into a version-controlled file 👍 I see that the Hammerspoon PR is still open. So, does this mean that a user must build Hammerspoon locally to run this branch? Apologies if I'm missing something obvious… |
I was hoping that the yabai PR would get merged to ignore hs.canvas windows until the Hammerspoon one is merged and released. |
Ah gotcha. I saw the comment thread on the yabai PR, and it doesn't look like it's not going to happen any time soon. If not having this merged is making it harder for you to develop further, I'll merge it, but I don't see a reason to merge it otherwise. |
Unfortunately the flicker is still there and it is caused by reacting to the
window_destroyed
event on Hammerspoon canvas windows.I hope we can fix this in Hammerspoon itself by using the standard
AXUnknown
subrole for its windows to have them filtered out by yabai.