Drop adde-lint, use eslint directly for "lint:js" run-script #1163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the "lint:js" run script, drop the usage of the custom
@addepar/ember-toolbox
-suppliedember adde-lint
command, replacing it with direct usage ofeslint
instead.Technically speaking, this is broader lint coverage than we had before.
The adde-lint command (as in
ember adde-lint
) is defined at Addepar/addepar-ember-toolbox@897b838/index.js#L29-L44For --javascript, the lint subcommand code concats the STANDARD_APP_FILES and STANDARD_APP_PATHS (defined here) and then filters out any that don't exist. It passes those as explicit args to the eslint command.
It seems more future-safe to lint using the catchall
.
.In order to make linting work correctly I had to add
dist/
to the.eslintignore
file.I used
DEBUG=eslint:cli-engine npx eslint .
(from stackoverflow, here: https://stackoverflow.com/questions/70284958/how-to-list-files-being-linted-by-eslint) to double-check which files are linted.