Skip to content

Add new @include directive option for adding modifiers to every filter list rule #190

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jellizaveta opened this issue Oct 4, 2023 · 0 comments

Comments

@jellizaveta
Copy link
Contributor

jellizaveta commented Oct 4, 2023

Some information

Mail has a kind of tracking - tracking pixel - that should be blocked. In filter lists this kind of tracking is blocked by such rule form:

link.pet-supermarket.co.uk$image

This type of rules was chosen because in mail clients images are loaded via proxy and the full address of such images looks like this:

ci4.googleusercontent.com/proxy/r62*-*-*#https://link.pet-supermarket.co.uk/img/*.gif

List of cname records of this tracker:
https://github.com/AdguardTeam/cname-trackers/blob/master/data/clickthroughs/sailthru.txt

Problem

Creating a separate list with such rules in cname repository looks irrelevant to the topic of this repository.
I would like updates from cname repository to be include into filter lists, and domains to be formatted in the right way for the blocker.

Suggestion

Add a new option for the @include directive — similar to /stripComments and /notOptimized — for adding modifiers to every rule in a filter list, i.e. adding $imagemodifier (for main tracking cname list) or some other ones for other purposes.
So it could be:

@include filter-list1.txt /addModifiers="image"
@include filter-list2.txt /addModifiers="image,script"
@include filter-list3.txt /addModifiers="script,redirect=noopjs"

Related issue

AdguardTeam/cname-trackers#85

@slavaleleka slavaleleka changed the title add hint for email tracking cname lists Add new @include directive option for email tracking cname lists Oct 9, 2023
@slavaleleka slavaleleka changed the title Add new @include directive option for email tracking cname lists Add new @include directive option for adding modifiers to every filter list rule Oct 16, 2023
@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop Oct 18, 2023
adguard pushed a commit that referenced this issue Nov 10, 2023
…st rules. #190

Squashed commit of the following:

commit 1511d4b
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Fri Nov 10 18:36:47 2023 +0300

    fixed changelog

commit 8f8d1ff
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Nov 10 18:27:32 2023 +0300

    CHANGELOG.md edited online with Bitbucket

commit 107c27e
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Fri Nov 10 18:15:35 2023 +0300

    CHANGELOG.md edited online with Bitbucket

commit 5fde92f
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Fri Nov 10 18:06:34 2023 +0300

    fix typo

commit ba5793d
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Fri Nov 10 18:05:31 2023 +0300

    added changelog

commit a4b44e9
Merge: 5ef2398 ccbab0b
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Fri Nov 10 17:32:09 2023 +0300

    Merge branch 'master' into feature/AG-26447

commit 5ef2398
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Fri Nov 10 17:24:59 2023 +0300

    changed strings to constant

commit ec000f1
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Fri Nov 10 16:01:49 2023 +0300

    fixed jsDoc comment

commit 2839ebc
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Fri Nov 10 14:02:42 2023 +0300

    change the return type of the parseIncludeLine

commit 103b587
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Thu Nov 9 20:31:41 2023 +0300

    fix names and structure

commit f5b0cee
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Thu Nov 9 15:30:46 2023 +0300

    update addModifiers

commit 037b2a9
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Thu Nov 9 14:01:33 2023 +0300

    applying formatting based on the modifier's position in the line

commit 011d698
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Fri Oct 27 13:01:32 2023 +0300

    test

commit f3e0ccd
Merge: 4b58983 1898795
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Thu Oct 26 20:34:24 2023 +0300

    Merge branch 'feature/AG-26447' of ssh://bit.int.agrd.dev:7999/adguard-filters/compiler into feature/AG-26447

commit 4b58983
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Thu Oct 26 20:33:53 2023 +0300

    fixed: tests, comments

commit 1898795
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Oct 26 20:25:03 2023 +0300

    src/main/platforms/generator.js edited online with Bitbucket

commit 2031fd7
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu Oct 26 20:24:51 2023 +0300

    src/main/builder.js edited online with Bitbucket

commit 2fba41b
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Thu Oct 26 14:32:12 2023 +0300

    added support for justDomains comments, fixed tests

commit 01b54bd
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Wed Oct 25 12:37:25 2023 +0300

    fixed the tests

commit f3d9819
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Tue Oct 24 21:10:26 2023 +0300

    changed the finding attribute value

... and 7 more commits
adguard pushed a commit that referenced this issue Nov 13, 2023
Squashed commit of the following:

commit f0efdf9
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Nov 13 19:04:13 2023 +0300

    fix changelog online with Bitbucket

commit cce760b
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Nov 13 19:04:05 2023 +0300

    fix changelog online with Bitbucket

commit 3544de4
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Mon Nov 13 18:53:21 2023 +0300

    upd CHANGELOG.md

commit dd965dc
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Mon Nov 13 18:52:32 2023 +0300

    Upd CHANGELOG.md

commit 8c036ba
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Nov 13 18:50:22 2023 +0300

    CHANGELOG.md edited online with Bitbucket

commit 4e6f433
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Nov 13 18:50:10 2023 +0300

    src/main/builder.js edited online with Bitbucket

commit c512b87
Merge: 1d552c5 67d143b
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Mon Nov 13 18:49:50 2023 +0300

    resole conflicts

commit 1d552c5
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Mon Nov 13 18:33:56 2023 +0300

    upd CHANGELOG.md

commit de5f6ab
Author: Elizaveta Egorova <e.egorova@adguard.com>
Date:   Mon Nov 13 18:29:00 2023 +0300

    Fixed blank line filtering
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants