Skip to content

Deduplicating default implementations #109

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Apr 10, 2025
Merged

Conversation

goergisn
Copy link
Contributor

Summary

  • Fixes following scenario:
    • Protocols that get extended with default implementations that have an access level defined would show both in their public diff

Example

public protocol ProtocolWithDefaultImplementation {
    func function() -> String
}

extension ProtocolWithDefaultImplementation {
    public func function() -> String {
        return ""
    }
}

Copy link

✅ No changes detected

Comparing fix-extension-duplicates to main


Analyzed targets: FileHandlingModule, PADCore, PADLogging, PADOutputGenerator, PADPackageFileAnalyzer, PADProjectBuilder, PADSwiftInterfaceDiff, PADSwiftInterfaceFileLocator, ShellModule, SwiftPackageFileHelperModule

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.6% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

@goergisn goergisn merged commit a74d7dc into main Apr 10, 2025
2 of 3 checks passed
@goergisn goergisn deleted the fix-extension-duplicates branch April 10, 2025 13:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant