Skip to content

Correctly handling target resources #98

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Correctly handling target resources #98

merged 1 commit into from
Feb 10, 2025

Conversation

goergisn
Copy link
Contributor

Summary

  • Removing false duplicate output

Copy link

@goergisn goergisn merged commit 35b8aaa into main Feb 10, 2025
6 checks passed
@goergisn goergisn deleted the fix-package-targets branch February 10, 2025 14:32
@goergisn goergisn restored the fix-package-targets branch February 10, 2025 14:33
Copy link

⚠️ 2 public changes detected ⚠️

Comparing fix-package-targets to main

🔀2 Modifications

Package.swift

.targets

🔀 Modified

// From
.testTarget(name: "IntegrationTests", dependencies: [.target(name: "public-api-diff")], path: "Tests/IntegrationTests")

// To
.testTarget(name: "IntegrationTests", dependencies: [.target(name: "public-api-diff")], path: "Tests/IntegrationTests")

/**
Changes:
- Added resource .copy("/Users/runner/work/adyen-swift-public-api-diff/adyen-swift-public-api-diff/tmp-public-api-diff6A78E510-5FAF-405A-8D00-33A1C9CA5AD0/Tests/IntegrationTests/Resources/expected-reference-changes-swift-interface-private.md")
- Added resource .copy("/Users/runner/work/adyen-swift-public-api-diff/adyen-swift-public-api-diff/tmp-public-api-diff6A78E510-5FAF-405A-8D00-33A1C9CA5AD0/Tests/IntegrationTests/Resources/expected-reference-changes-swift-interface-public.md")
- Removed resource .copy("/Users/runner/work/adyen-swift-public-api-diff/adyen-swift-public-api-diff/tmp-public-api-diff5C0F6AF8-227D-4F88-AF8E-32BBAB911BE2/Tests/IntegrationTests/Resources/expected-reference-changes-swift-interface-private.md")
- Removed resource .copy("/Users/runner/work/adyen-swift-public-api-diff/adyen-swift-public-api-diff/tmp-public-api-diff5C0F6AF8-227D-4F88-AF8E-32BBAB911BE2/Tests/IntegrationTests/Resources/expected-reference-changes-swift-interface-public.md")
*/
// From
.testTarget(name: "UnitTests", dependencies: [.target(name: "public-api-diff")], path: "Tests/UnitTests")

// To
.testTarget(name: "UnitTests", dependencies: [.target(name: "public-api-diff")], path: "Tests/UnitTests")

/**
Changes:
- Added resource .copy("/Users/runner/work/adyen-swift-public-api-diff/adyen-swift-public-api-diff/tmp-public-api-diff6A78E510-5FAF-405A-8D00-33A1C9CA5AD0/Tests/UnitTests/Resources/expected-reference-changes.md")
- Removed resource .copy("/Users/runner/work/adyen-swift-public-api-diff/adyen-swift-public-api-diff/tmp-public-api-diff5C0F6AF8-227D-4F88-AF8E-32BBAB911BE2/Tests/UnitTests/Resources/expected-reference-changes.md")
*/

Analyzed targets: FileHandlingModule, PADCore, PADLogging, PADOutputGenerator, PADPackageFileAnalyzer, PADProjectBuilder, PADSwiftInterfaceDiff, PADSwiftInterfaceFileLocator, ShellModule, SwiftPackageFileHelperModule

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant