Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Allow newer flutter_lints versions #188

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

nate-thegrate
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • The GitHub Actions pass building and linting. Linter returns no warnings or errors.
  • The QA checklist below has been completed

The only linter message that came up due to this change was use_super_parameters. I applied the "quick fix" for each message, so now there are no longer any issues.


Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): dependency change

Summary of changes

This change removes the version restriction for the lints dependency.

# before
  lints: ">=1.0.1 <2.1.2"

# after
  lints: ">=1.0.1"

Once this change is implemented, developers who use this plugin won't be prevented from using new linting features.


Does this introduce a breaking change?

  • Yes
  • No

The lints package is just for static analysis, so there shouldn't be any impact on functionality.

@nate-thegrate
Copy link
Contributor Author

I just realized that this PR is almost identical to another pull request that has already been opened.

However, the other PR is set to ^3.0.0 instead of ">=1.0.1", which may cause version conflicts.

@nate-thegrate nate-thegrate mentioned this pull request Apr 26, 2024
23 tasks
Copy link
Contributor

@tadaspetra tadaspetra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tadaspetra tadaspetra merged commit 238e1dd into AgoraIO-Community:main Apr 29, 2024
1 check passed
tadaspetra added a commit to ebsangam/VideoUIKit-Flutter that referenced this pull request Apr 29, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants