Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: have bankSend accept from argument set to default as validator address #189

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anilhelvaci
Copy link
Contributor

Closes #187
Refs: https://github.com/Agoric/BytePitchPartnerEng/issues/27

tooling improvements

Improve bankSend to accept a parameter as from. Set it to validator account by default so it won't break existing usage.

@anilhelvaci
Copy link
Contributor Author

Not able to request review (gh disables it). Could you please take a look at this? @turadg

@turadg
Copy link
Member

turadg commented Oct 31, 2024

Let's make these improvements in agoric-sdk instead. That'll require Agoric/agoric-sdk#10369

Meanwhile just make a library in z:acceptance

(I recently requested that a new bankSend in a PR be made compatible with the existing signature, which just meant to update it there)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bankSend assumes the validator account is only possible sender
2 participants