Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: reflect minimum go version #11084

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ packages/stat-logger
**/__pycache__
**/*.egg-info
**/swingset-kernel-state
**/.cache
**/_agstate
.vagrant
endo-sha.txt
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ to use.
Prerequisites are enforced in various places that should be kept synchronized with this section (e.g., [repoconfig.sh](./repoconfig.sh) defines `golang_version_check` and `nodejs_version_check` shell functions).

* Git
* Go ^1.20.2
* Go ^1.22.12
* Node.js ^18.12 or ^20.9
* we generally support the latest LTS release: use [nvm](https://github.com/nvm-sh/nvm) to keep your local system up-to-date
* Yarn (`npm install -g yarn`)
Expand Down
7 changes: 4 additions & 3 deletions repoconfig.sh
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@
#! /bin/sh
# shellcheck disable=SC2034
NODEJS_VERSION=v20
GOLANG_VERSION=1.22
GOLANG_VERSION=1.22.12
GOLANG_DIR=golang/cosmos
GOLANG_DAEMON=$GOLANG_DIR/build/agd

# golang_version_check $major $minor $patch $version
golang_version_check() {
# Keep synchronized with README.md section "Prerequisites".
{
[ "$1" -eq 1 ] && [ "$2" -ge 22 ] && return 0
[ "$1" -eq 1 ] && [ "$2" -eq 22 ] && [ "$3" -ge 12 ] && return 0
[ "$1" -eq 1 ] && [ "$2" -ge 23 ] && return 0
} 2> /dev/null
echo 1>&2 "need Go version 1.22+, found $4"
echo 1>&2 "need Go version $GOLANG_VERSION+, found $4"
return 1
}

Expand Down
Loading